Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package updates #67

Merged
merged 6 commits into from
Aug 18, 2022
Merged

package updates #67

merged 6 commits into from
Aug 18, 2022

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

Are you a current Fivetran customer?

Fivetran create PR

What change(s) does this PR introduce?

This PR applies the package standardization updates to the package discussed within the team to be more consistent in our documentation and style.

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

This won't necessarily be breaking. However, this will be a major change to the look and feel of our package. Therefore, I believe this should be a breaking change.

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

  • Yes, Issue/Feature [link bug/feature number here]
  • No

How did you test the PR changes?

  • CircleCi
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

📜

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

Copy link
Contributor

@fivetran-reneeli fivetran-reneeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fivetran-jamie
Copy link
Collaborator

@fivetran-joemarkiewicz should this be merged?

@fivetran-reneeli
Copy link
Contributor

Yeah I realized the source package wasn't update either!

@fivetran-joemarkiewicz
Copy link
Contributor Author

@fivetran-reneeli and @fivetran-jamie thanks for calling this out. Let's discuss this as a team during standup, but I do think this (or at least a version of this) should be included in the next release.

@fivetran-jamie fivetran-jamie changed the base branch from main to release/v0.5.5 August 18, 2022 21:11
@fivetran-jamie fivetran-jamie merged commit 0dd1094 into release/v0.5.5 Aug 18, 2022
@fivetran-jamie fivetran-jamie deleted the feature/package-updates branch August 18, 2022 23:18
This was referenced Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants